nutti / fake-bpy-module

Fake Blender Python API module collection for the code completion.
MIT License
1.37k stars 97 forks source link

Make GitHub Actions testable on local docker #173

Closed UuuNyaa closed 9 months ago

UuuNyaa commented 9 months ago

Purpose of the pull request

Description about the pull request

nutti commented 9 months ago

@UuuNyaa

Thanks for your contribution! This is a very interesting idea.

But I'm not familiar with Dev Container, so I need to spend a time to check this PR. After my confirmation is finished, I will try to merge this PR.

BTW, your commit fails our lint checker. Could you fix the error?

UuuNyaa commented 9 months ago

@nutti Thank you for the response.

I realized that we don't need to use devcontainers. So I will add a tests/run_github_actions_test.sh script and launch docker from the script to test github actions. Therefore please do not merge this pull request yet.

BTW, your commit fails our lint checker. Could you fix the error?

Yes, I will fix this lint error.

By the way, the VSCode configuration files have JSON extension syntax called JSON with Comments, which formally accepts comments and trailing commas.

UuuNyaa commented 9 months ago

@nutti GitHub actions can now be tested using the following commands:

Please merge after your review.

UuuNyaa commented 9 months ago

@nutti Thanks for your review! I have fixed what you pointed out.

nutti commented 9 months ago

@UuuNyaa

This PR makes a build error about the latest build. https://github.com/nutti/fake-bpy-module/actions/runs/7406135409

I think this error comes from the version of actions/download-artifact. If I revert to the previous version, it works fine. Change: https://github.com/nutti/fake-bpy-module/commit/4812b5cf298863b435f07dcd24df3b27b276d2e0 Result: https://github.com/nutti/fake-bpy-module/actions/runs/7406455630

Could you check this error?

nutti commented 9 months ago

@UuuNyaa

I changed the version of actions/download-artifact to v3 for now. https://github.com/nutti/fake-bpy-module/commit/b917e3329dc5e040965ab979cb18e14972087709

UuuNyaa commented 9 months ago

I changed the version of actions/download-artifact to v3 for now. b917e33

Thank you for the correction. I think I missed the problem because I can't run the PyPI test in my environment.

nutti commented 9 months ago

@UuuNyaa

No prob. I added the latest build test to CI/CD. It can detect the error for the latest build.