Closed JonathanPlasse closed 2 weeks ago
@nutti, would you prefer a line-length other than 88? Is there any other part of the code, you would like to keep manually formatting? I would like to merge this as soon as possible to avoid merge conflict and having to rebase.
@JonathanPlasse
Thank you for your continuous work. I will check them. However, I can not review this PR quickly because I will be busy next week.
No problem, as long as it is the first PR you merge, it is fine as there will not be any merge conflict.
Thank you for being active, I am really glad seeing this project moving forward and being part of it.
@JonathanPlasse
Currently, build test for latest version will be failed. I have already reported this issue and will be fixed in the tomorrow. https://projects.blender.org/blender/blender/issues/122305
@JonathanPlasse
I'm now experimenting the ruff linter. After the experiment, I will propose a configuration file which matches this project. Also we should follow same GitHub Action job as markdownlint and so on (by calling shell script instead of calling ruff command directly).
Indeed, I do not think the Ruff formatter fit this project. I will switch to the Ruff linter with formatting rules with auto-fix.
Thank you for your consideration. I think some ruff rules are useful for our project to clean our code, so I will adopt ruff linter to this project .
@JonathanPlasse
This requires a time to finish. Is it possible to pause this PR for now? If I ready to share, I will ping you again.
Yes, you can close the pull request.
Purpose of the pull request
Description about the pull request
# fmt: skip
where we want to keep manual formatting (e.g. Blender version)