search

nutti / fake-bpy-module

Fake Blender Python API module collection for the code completion.
MIT License
1.31k stars 95 forks source link

Replace deprecated aliases to ABCs in collections.abc #223

Closed Road-hog123 closed 1 month ago

Road-hog123 commented 1 month ago

A continuation of the work towards resolving #161 that was started in #207—typing.Sequence, typing.Iterable, typing.Iterator and typing.Callable are all deprecated aliases to types of the same name in collections.abc.

I'm certainly not familiar with the codebase yet, so I'm submitting this now for checks and review even though it conflicts with #221.

nutti commented 1 month ago

@Road-hog123

Thank you for your contribution! After your work, please remove WIP status. And then I can review it.

nutti commented 1 month ago

@Road-hog123

Build test for latest version will be failed for now. I reported this issue and will be fixed in the tomorrow. https://projects.blender.org/blender/blender/issues/122305

nutti commented 1 month ago

@Road-hog123

The code looks good to me. To solve the Lint error, could you rebase to the newest master branch?

Road-hog123 commented 1 month ago

I reported this issue and will be fixed in the tomorrow. https://projects.blender.org/blender/blender/issues/122305

Ah, good to know the segfault is fixed, now I can work on BMesh fixes again. 😄

nutti commented 1 month ago

@Road-hog123 Thank you for your contribution! This PR is merged now.