search

nutti / fake-bpy-module

Fake Blender Python API module collection for the code completion.
MIT License
1.35k stars 96 forks source link

Add: Cleanup old artifacts #60

Closed grische closed 4 years ago

grische commented 4 years ago

Purpose of the pull request
Clean up old artifacts automatically.

Description about the pull request
This PR is a split from #51 and only makes sense if #51 is merged.

It might be worth noting, that external repositories on Github Actions (i.e. c-hive/gha-remove-artifacts) require trust in the third party as it can contain malicious code (and malicious code can be added easily later) as far as I am aware. That's why I split the feature into a separate commit.

I measured the build artifacts we are creating and they are in total around 10MB for each commit to master. It seems, Github has no limit on build artifacts (but when they reach around 5GB, it seems a bug is triggered): https://github.com/actions/upload-artifact/issues/9

This means that for 500 builds/commits everything is fine and by the time this repo reaches 500 builds on master, the bug is probably already fixed.

Would you like to have this PR?

grische commented 4 years ago

You can also close the PR if you prefer not to have it, I have no strong feelings either way.

nutti commented 4 years ago

@grische

Thanks! I think we should pass this PR for now because we could not forecast https://github.com/c-hive/gha-remove-artifacts will continue supporting. Also, commits in this repository will not reach the limitation of Storage in current situation.

From my understanding, all artifacts which are over 90 days will be deleted automatically. So, I think it is enough for this project.

I think we should wait until this issue becomes problem. What do you think?

grische commented 4 years ago

Agreed. I will leave this PR here for the future.