search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://notes-foss.com
Mozilla Public License 2.0
3.78k stars 333 forks source link

UpdaterWindow doesn't have proper Window decorations on Linux #347

Open DesiOtaku opened 2 years ago

DesiOtaku commented 2 years ago

On KDE, the regular window shows a proper border + shadow so it works fine on a white background. However, UpdaterWindow ignores the KDE Qt style and blends in to the white background.

Also the "Close" and "Update" button isn't consistent with the rest of the Qt style (it looks more like Android rather than KDE).

DesiOtaku commented 2 years ago

image

nuttyartist commented 2 years ago

Thanks for reporting, we'll look into that.

guihkx commented 1 year ago

Fixed by #469.

bjorn commented 1 year ago

Fixed by #469.

@guihkx Really? Did you test it? We're still setting Qt::CustomizeWindowHint on the updater window so it will not have a native decoration. It might be nice to follow the same configuration as for the main window.

Also the "Close" and "Update" button isn't consistent with the rest of the Qt style (it looks more like Android rather than KDE).

@DesiOtaku Note that their style has been intentionally customized. There is currently no option for using the native widget style.

guihkx commented 1 year ago

@bjorn It "works", but I just noticed that's maybe because frameless mode seems to be ignored altogether on Wayland now... :/

KDE Plasma

image

GNOME

Screenshot from 2023-02-13 09-15-28

bjorn commented 1 year ago

It "works", but I just noticed that's maybe because frameless mode seems to be ignored altogether on Wayland now... :/

On the KDE screenshot I don't see the updater window (though I guess it doesn't matter, since it would indeed just have the native frame, judging by the main window).

Does that mean we need to put back the Qt::FramelessWindowHint on Linux? I can't personally test on Wayland due to using proprietary NVidia drivers.

guihkx commented 1 year ago

On the KDE screenshot I don't see the update window.

Dang it, I uploaded the wrong one. But it matches GNOME's.

Regarding frameless mode not working on Wayland, could that mean we need to put back the Qt::FramelessWindowHint on Linux?

Precisely. After I re-added that to mainwindow.cpp and updaterwindow.cpp, native decorations in frameless mode are now gone, at least:

Screenshot from 2023-02-13 09-40-33

But this bug still persists. I'll re-open it and send a pull request once after I finish some chores (but feel free to take over, if you want).