nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://notes-foss.com
Mozilla Public License 2.0
3.81k stars 338 forks source link

Build fixes for CMake and GitHub Actions #437

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

Sorry for the rather large pull request, but all the changes are kind of connected... So take your time to review it!

Possible highlights:

Happy new year! 🎉

zjeffer commented 1 year ago

Shouldn't we also support ubuntu22.04?

guihkx commented 1 year ago

Shouldn't we also support ubuntu22.04?

You mean in the context of the CI pipeline? If so, I believe we already cover that:

Although I just noticed that the Qt 5 job is using ubuntu-latest instead of ubuntu-22.04, for some reason... lol

Currently it doesn't matter, since they refer to the same runner, but I think we should use ubuntu-22.04 on both, to avoid ambiguity.

zjeffer commented 1 year ago

Although I just noticed that the Qt 5 job is using ubuntu-latest instead of ubuntu-22.04, for some reason... lol

Currently it doesn't matter, since they refer to the same runner, but I think we should use ubuntu-22.04 on both, to avoid ambiguity.

Ah, I must have missed it.

nuttyartist commented 1 year ago

Works well on my Mac (: 👍 And happy new year!

guihkx commented 1 year ago

Awesome!

Thank you guys, I'll merge it then.