search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://notes-foss.com
Mozilla Public License 2.0
3.73k stars 328 forks source link

CI: Set additional CMake properties for macOS builds #442

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

Warnings from the build step:

CMake Warning (dev) in CMakeLists.txt:
  uninitialized variable 'MACOSX_BUNDLE_INFO_STRING'
-- Generating done
This warning is for project developers.  Use -Wno-dev to suppress it.
-- Build files have been written to: /Users/runner/work/notes/notes/build

CMake Warning (dev) in CMakeLists.txt:
  uninitialized variable 'MACOSX_BUNDLE_GUI_IDENTIFIER'
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  uninitialized variable 'MACOSX_BUNDLE_LONG_VERSION_STRING'
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  uninitialized variable 'MACOSX_BUNDLE_BUNDLE_NAME'
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  uninitialized variable 'MACOSX_BUNDLE_SHORT_VERSION_STRING'
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  uninitialized variable 'MACOSX_BUNDLE_BUNDLE_VERSION'
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) in CMakeLists.txt:
  uninitialized variable 'MACOSX_BUNDLE_COPYRIGHT'
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake documentation: https://cmake.org/cmake/help/v3.10/prop_tgt/MACOSX_BUNDLE_INFO_PLIST.html

@nuttyartist What should we use for MACOSX_BUNDLE_GUI_IDENTIFIER?

As we discussed previously, the app id I ended up using for our future Flatpak app is: io.github.nuttyartist.notes.

Do you want to re-use that same app id, or use a different one?

guihkx commented 1 year ago

Aside: In the discussion I linked, I actually said I was going to use com.github.nuttyartist.notes, and not io.github.nuttyartist.notes.

But that was before recent changes to Flatpak naming rules, which now state the following:

For some practical examples of bad IDs:

  • com.github.foo.Bar:

    While a project may be hosted on GitHub it does not have any control over the github.com domain. Instead you should use io.github as shown above.

nuttyartist commented 1 year ago

The same one should be fine io.github.nuttyartist.notes. Thanks! 👍