Build: Enable extra compiler warnings by default

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.

https://notes-foss.com

Mozilla Public License 2.0

3.72k stars 326 forks source link

Build: Enable extra compiler warnings by default #473

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

This enables some extra warnings on supported compilers, by default. The options are:

GCC/Clang: -Wall -Wextra -Wpedantic -Wshadow
MSVC: /W4

For obvious reasons, these flags had to be disabled on third-party sources, that's why I moved them into their own list in CMakeLists.txt.

guihkx commented 1 year ago

Oh, dear god. lol

And to think the only part I was questioning myself about was the removal of QFile noteDBFile(noteDBFilePath);, which I confidently ended up thinking was okay after reading the documentation... 🤡

It only goes to show how much I have to learn. :~

@bjorn Thank you so much for taking your time to review this!

It's a bit late for me now and I have to rest, but I'll try to address every point as soon as I can...

guihkx commented 1 year ago

Round 2...

Besides addressing every point (or rather, trying to), I added an extra fix for the code that handles the v1.5.0 database migration to the new format. I basically just got rid of this warning:

QSqlQuery::value: not positioned on a valid record

Thanks!

guihkx commented 1 year ago

Just to be extra sure before I merge this, @bjorn could you please take a final look?

Thank you for reviewing and for your patience, by the way! 🏆

guihkx commented 1 year ago

Thank you all! Merging...