search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://notes-foss.com
Mozilla Public License 2.0
3.72k stars 326 forks source link

Add CMake option to disable auto-updating features #474

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

This option allows us to build Notes without any sort of update checking code (including the auto-updater).

This is mostly useful for Linux package maintainers, where any update checking feature is essentially useless, since we don't (and shouldn't) have control over a Linux distribution's package upgrading process.

Nevertheless, this option is still enabled by default, meaning that both the update checker and the auto-updater will still work.

To disable them, invoke CMake with -DUPDATE_CHECKER=OFF.

nuttyartist commented 1 year ago

Good feature to have for Linux users (or anyone using some package manager to install Notes), and good that you kept it on by default.

But it's critical to test that it works right and that updates are really being fetched. Can you try verify this by changing your local executable version to less than 2.0.0 and see if the updater automatically fetches version 2.0.0?

nuttyartist commented 1 year ago

Okay, I've tested it, and it works just fine still. 👍 Thanks!

guihkx commented 1 year ago

Thanks, guys! Merging...