search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://notes-foss.com
Mozilla Public License 2.0
3.77k stars 333 forks source link

Tab width is way too high, fixed by setting it to the width of 4 spaces. #479

Closed zjeffer closed 1 year ago

zjeffer commented 1 year ago

I felt the tab with is waaay too high (8 spaces), which is very annoying for making todo lists with indented items. I changed this to use 4 spaces instead. In the future, we could let the user choose this width through a preferences window.

Old:

https://user-images.githubusercontent.com/4633209/219814567-c7e544c4-abf0-4ccb-baa3-8a636414d338.mp4

New:

https://user-images.githubusercontent.com/4633209/219814550-725f536c-bf7d-43b1-b56e-d28b57a640f1.mp4

This updates every time the theme changes.

An alternative to this PR is to catch the Tab keyboard event and to insert 4 spaces instead. I don't think this is a good idea as existing notes would still have the long tabs, and this feels kind of hacky anyway.

nuttyartist commented 1 year ago

Oh this is an immediate merge for me, thanks!

(Waiting for others to review the code)

zjeffer commented 1 year ago

I haven't tested this on Qt < 5.11 yet, though. I don't have a VM ready for that. Can someone else test this on something like ubuntu18.04?

guihkx commented 1 year ago

Can someone else test this on something like ubuntu18.04?

Done. Works exactly as showcased on your second video.

nuttyartist commented 1 year ago

I'll try to do all the testing for 2.1.0 tonight. @guihkx What do you think about the automatic signing and notarization? Possible for 2.1.0 or the next version?

guihkx commented 1 year ago

@nuttyartist I haven't taken a deep look into that yet, unfortunately... :/

So I think we might have to postpone it to the next release, as I'm not familiar with the process at all.

Before you release 2.1.0 though, there is this minor regression (I just opened an issue about it), that might be worth it getting fixed first.

nuttyartist commented 1 year ago

@nuttyartist I haven't taken a deep look into that yet, unfortunately... :/

So I think we might have to postpone it to the next release, as I'm not familiar with the process at all.

Before you release 2.1.0 though, there is this minor regression (I just opened an issue about it), that might be worth it getting fixed first.

Alrighty, I'll try to sign and notarize on my local machine for this release (If I'd manage).

And yes, just saw it, we'll need to take care of it.