Added version to About window

[zjeffer]

closes #485

I added the app version and qt version at the bottom of the About window, here's how it looks on Ubuntu22.10:

It uses the app version from the CMakeLists.txt file, so here it shows I'm using the AppImage from a GitHub action.

[guihkx]

Nice. Thanks for opening this PR.

If I may suggest something, I think this information would make more sense at the very top instead (because of its relevancy).

Also, couldn't we add what Qt version was used to build Notes too? Maybe something like:

Qt version: 5.15.8 (built with 5.15.2)

[zjeffer]

New location + "(built with x)" added:

[zjeffer]

I'm not sure what's the best way to test whether the compiled version & runtime version are correct. I guess the AppImages always have the same version?

[guihkx]

It might look a bit out of place there, but I still think it should be at the very top somehow, so LGTM as an initial design. :p

I guess the AppImages always have the same version?

They have. The runtime version will only really change in case Notes is using a distro's Qt package, as they might update independently from us.

[nuttyartist]

Great. But please move the QT version to the bottom of the page (keeping only the app version at the top). Our app is used by many who are not programmers. Most of them don't need to see that info at the top. But it's good the app version stays at the top.

[zjeffer]

Ok, it looks like this now:

Either way, I think we should do a complete redesign of the About window in the future.

[nuttyartist]

Either way, I think we should do a complete redesign of the About window in the future.

Definitely.

Feel free to merge after addressing @bjorn's comment