Issues with Windows build for 2.1.0

[nuttyartist]

I'm testing the Windows build now. While there aren't major issues, here are some points:

~1. Clicking on the Notes icon in the task manager doesn't seem to minimize it back to the task manager (although system tray works well). I forgot if it's a known problem or not.~ EDIT: doesn't seem like a problem anymore.

2. Some windows have a question mark button on their title bar:
3. Many styling issues. Many buttons look extremely old. See the scroller in the Updater window above and the About window. And the tick box in the updater window. Also here in these buttons and context menu:

Is it only solved by custom styling?

BTW, I'm getting an error trying to compile Notes. I want to test a couple of things (making sure updater works, some styling things, etc...). Any idea how can I solve this?

[bjorn]

2. Some windows have a question mark button on their title bar:

I guess you were testing with Qt 5 builds? Since this question mark should be disabled by default in Qt 6. For Qt 5 builds, we can get rid of it by setting an application attribute:

#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
    QCoreApplication::setAttribute(Qt::AA_DisableWindowContextHelpButton);
#endif

(Not sure what is our minimum Qt version, but this attribute is available since Qt 5.10 - before that, the Qt::WindowContextHelpButtonHint window flag had to be disabled for each window separately)

3. Many styling issues. Many buttons look extremely old. See the scroller in the Updater window above and the About window. And the tick box in the updater window. Also here in these buttons and context menu:

Looks like we're not shipping the Windows Vista style plugin, which should be in plugins\styles\qwindowsvistastyle.dll.

BTW, I'm getting an error trying to compile Notes. I want to test a couple of things (making sure updater works, some styling things, etc...). Any idea how can I solve this?

Not sure why CMake can't find the compiler. Is a suitable compiler selected in the selected Kit (see Projects > Manage Kits)?

[nuttyartist]

I guess you were testing with Qt 5 builds?

You're right, this doesn't occur with the Qt6 build.

But I used the installer to install the app, why did it pick the Qt5 build over Qt6?

For Qt 5 builds, we can get rid of it by setting an application attribute:

That's should be better.

Not sure why CMake can't find the compiler. Is a suitable compiler selected in the selected Kit (see Projects > Manage Kits)?

I reinstalled Qt with Mingw and now everything works fine. I tested the updater and everything seems to work well.

[guihkx]

But I used the installer to install the app, why did it pick the Qt5 build over Qt6?

That seems wrong. The Qt 5 build should only be chosen on 32-bit Windows (or Windows 7, which doesn't support Qt 6).

[nuttyartist]

That's weird, then... Can you reproduce the issue?

[guihkx]

I can, actually... I'll send a PR to fix it.

[nuttyartist]

We can close this due to #502 :)