Windows Installer: Don't install both Qt builds

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.

https://notes-foss.com

Mozilla Public License 2.0

3.77k stars 333 forks source link

Windows Installer: Don't install both Qt builds #502

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

We were incorrectly installing both Qt 5 and Qt 6 builds on Windows 8 and newer.

The Qt 5 build should only be installed on Windows 7, or on 32-bit versions of Windows.

I also added the ExtraDiskSpaceRequired option to work around a possible bug in Inno Setup ([1], [2]), where it's unable to calculate the minimum required disk space to install the app, so it ends up reporting only 3.1 MB:

This was noticed by @nuttyartist in #496. Thanks!

nuttyartist commented 1 year ago

Great, I'll test this.

nuttyartist commented 1 year ago

It's probably still using Qt5?

Screen Shot 2023-02-27 at 1 11 48 PM Screen Shot 2023-02-27 at 1 12 08 PM

BTW, not related, but I think the installer default should be to check the option for creating a desktop icon.

guihkx commented 1 year ago

Oh, there was a bunch of copy/paste mistakes in the Inno Setup file while creating directories, that's what was causing the theming issue when the app was installed (the "portable" version was fine). 🤦

I fixed all of them now, please retest. :)

I think the installer default should be to check the option for creating a desktop icon.

Okay, I did that too. Keep in mind that the installer remembers what options you chose in a previous installation, so if you want to test this, make sure to uninstall any previous version of Notes first.

nuttyartist commented 1 year ago

Yay, works well now, thanks!