search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://notes-foss.com
Mozilla Public License 2.0
3.77k stars 333 forks source link

UI: Get rid of the "context help" button #509

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

We currently don't do anything with it, and the button is disabled by default on Qt 6, so let's also disable it on Qt 5 builds.

This was reported in #496, and this fix is based on https://github.com/nuttyartist/notes/issues/496#issuecomment-1441486941! :)

zjeffer commented 1 year ago

I can't test it on Windows right now, but does the styleeditorwindow not have this problem?

zjeffer commented 1 year ago

Also, setWindowFlag(Qt::WindowContextHelpButtonHint, false); also works on Qt6 (even thought the default is false anyway), maybe it's cleaner to drop the #ifdefs? Not sure what the convention is there.

nuttyartist commented 1 year ago

Works well. In my testing, also the look of the UI is not old as before for some reason (it looks like the Qt6 version).

I think we can release 2.1.0 on Monday, what do you say?

guihkx commented 1 year ago

but does the styleeditorwindow not have this problem?

Not really... Maybe because it derives from QDialog?

Also, setWindowFlag(Qt::WindowContextHelpButtonHint, false); also works on Qt6 (even thought the default is false anyway), maybe it's cleaner to drop the #ifdefs? Not sure what the convention is there.

Sure, I'd be fine with that. I'm also not sure what's the preferred solution is though, so I'll let @nuttyartist decide.

Works well. In my testing, also the look of the UI is not old as before for some reason (it looks like the Qt6 version).

That was fixed in 2eeb9cf3dcb8e922dab46c5e830ca818a24a0ea6. The styling plugin was being installed in the wrong place.

I think we can release 2.1.0 on Monday, what do you say?

Sounds good to me. I have some very easy fixes (mostly related to packaging), so I'll try to push them all today.

bjorn commented 1 year ago

Sure, I'd be fine with that. I'm also not sure what's the preferred solution is though, so I'll let @nuttyartist decide.

I like the #ifdefs because it also clearly marks the code as ready for removal, in the event that we'd drop support for Qt older than 5.10.

guihkx commented 1 year ago

Oh, that's also a good point. Let's keep this as-is then.

Thanks!