Editor settings improvements

[zjeffer]

@darthagnon reported (https://github.com/nuttyartist/notes/issues/521) some issues with the editor settings window:

• Aa settings x3, overlapping with font names, and multiple microscopic Next buttons (I'm guessing this is font settings, but it's broken for me)
• Unlabelled +/- buttons (Trial and error: font size)
• Unlabelled Full Width ➡⬅ buttons (uncertain purpose)
• Reset all settings button is very prominent and large... there's not that many settings that would ever need resetting, and Reset All shouldn't be that easy to click in my opinion.

[Darthagnon]

I'd also suggest merging the Editor Settings with the program settings . . . hamburger menu, under a Gear or hamburger icon.

[zjeffer]

Proposals:

• Make the editor margins a slider instead of 3 buttons (https://doc.qt.io/qt-6/qslider.html)
• Make the font a spin box (https://doc.qt.io/qt-6/qspinbox.html)
• Make the font selection a Font Combo box (https://doc.qt.io/qt-6/qfontcombobox.html), but we would need to find a way to make it clear which type of font (sans, serif, mono) each font belongs to. A simple list of fonts in a combo box doesn't really show that.
• Instead of light/dark/sepia, we show a label "Theme: " with the actual colors as buttons.
• Move all these settings to a separate settings window, accessible with the gear icon. Move other relevant settings (like native window decorations) to this window as well.

What do you guys think?

[nuttyartist]

Make the editor margins a slider instead of 3 buttons (https://doc.qt.io/qt-6/qslider.html)

I don't like this. I hate sliders when you want preciosion. The buttons allow you to change the margins by one character each time.

Make the font a spin box (https://doc.qt.io/qt-6/qspinbox.html)

Hmm make sense for a font. I like the current way because it shows you how the fonts look like. So either we use selection using a spinbox and keep the preview, or we improve the button to be more clickable?

Instead of light/dark/sepia, we show a label "Theme: " with the actual colors as buttons.

That makes sense. I'll try to see how it will look if I incorporate that into the existing mockup.

Move all these settings to a separate settings window, accessible with the gear icon. Move other relevant settings (like native window decorations) to this window as well.

That's a good idea. We can move more settings there.

• Start automatically.
• Hide to tray What do you think?

I created a mockup. It's very much rough.

• We probably are better off using the Tab widget than implementing a custom one?
• I think we can make the Reset to Default a small QPushbutton inside its area so the error rate of clicking it is decreased.
• I'm not sure showing the colors the way I did looks nice. But maybe you can come up with better solutions?

[nuttyartist]

Adding:

• [ ] Show the currently selected font index and the total amount of fonts. That way people can better understand they should click again to find more fonts. "2/5", etc...

[nuttyartist]

Changing position here. I think we should convert the 3 dots menu in the editor to contain "style, export" and other settings related to the specific opened note, the way Notion is doing (see picture below). And create a dedicated app setting on the folders pane, the way Bear does it (I'll change #541 accordingly).

Notion:

Bear:

[nuttyartist]

Done in #589