search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://www.get-notes.com
Mozilla Public License 2.0
3.68k stars 319 forks source link

Make windows use native window decorations by default #526

Closed zjeffer closed 1 year ago

zjeffer commented 1 year ago

Users have reported (#521) that it would be better if Windows used native window decorations by default. This PR sets that.

(not tested yet but I assume this small change works fine)

Closes #525

guihkx commented 1 year ago

In my opinion, we should not be changing options set by the user (as some may prefer custom decorations, for example).

A safer approach, in my opinion, would be using native window decorations by default when our config file is not present (i.e., it's the first time the program is running).

zjeffer commented 1 year ago

A safer approach, in my opinion, would be using native window decorations by default when our config file is not present

That's what this PR does, no?

guihkx commented 1 year ago

Oh, you're right. The second parameter of value() sets the default one.

In any case, I'll test this shortly.

zjeffer commented 1 year ago

Thanks for testing!

zjeffer commented 1 year ago

@nuttyartist On the get-notes.com homepage, under the "Cross-platform" header there's a screenshot for every platform. I think we should update the Windows screenshot with one using native decorations now.