search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://notes-foss.com
Mozilla Public License 2.0
3.75k stars 329 forks source link

Updated qmarkdowntextedit submodule #549

Closed bjorn closed 1 year ago

bjorn commented 1 year ago

Notable changes:

However, if we look at the before and after images, we see that our font family option is no longer being taken into account by the bold and italic sections:

Before: Screenshot from 2023-03-17 11-42-20

After: Screenshot from 2023-03-17 11-42-40

So I'm proposing a fix to QMarkdownTextEdit first: https://github.com/pbek/qmarkdowntextedit/pull/179

bjorn commented 1 year ago

So I'm proposing a fix to QMarkdownTextEdit first: pbek/qmarkdowntextedit#179

Merged, so I've updated submodule. :-)

bjorn commented 1 year ago

Maybe somebody could confirm whether the Home/End key handling is really better under macOS? Though I'm not sure what it is about exactly, it might depend on user configuration different from macOS default.

nuttyartist commented 1 year ago

Nice!

Maybe somebody could confirm whether the Home/End key handling is really better under macOS? Though I'm not sure what it is about exactly, it might depend on user configuration different from macOS default.

I'm not sure what changed here. Pressing Command-Left Arrow or Right Arrow and Fn–Left Arrow or Right Arrow seems to work the same way.

bjorn commented 1 year ago

I'm not sure what changed here. Pressing Command-Left Arrow or Right Arrow and Fn–Left Arrow or Right Arrow seems to work the same way.

Yeah, I think this fix was for people that changed the default behavior, as in #1593.

bjorn commented 1 year ago

Ah, also, all the changes to the Home/End key handling are made to the QMarkdownTextEdit widget:

So, they do not affect Notes at all since we're not using that class. We instead use the rather badly named CustomDocument widget. It means we may want to look into porting that change over, though I'd leave that to somebody who could reproduce the relevant issue on macOS.

(and if we don't, this is not something that should be mentioned in our release notes)