nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://www.get-notes.com
Mozilla Public License 2.0
3.68k stars 319 forks source link

CI: Create RPM packages for Fedora 36 and openSUSE Leap 15 #551

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

We now create RPM packages for the following Linux distributions:

The rationale for choosing those specific versions is simple: They're the oldest, yet still supported releases.

We also tell CMake to build a position independent executable (PIE) to get rid of this warning given by rpmlint:

notes.x86_64: W: position-independent-executable-suggested /usr/bin/notes

Likewise with the DEB package, there's also some other warnings related to missing documentation, but those can be addressed in the future.


P.S.: There's an unrelated change in this PR: I've bumped our C++ standard to C++17, which Qt 6 already asks for anyway. And even though we still support Qt 5, this change shouldn't be too much of an issue, because it's possible to install a C++17-compatible compiler on older platforms we still support.

guihkx commented 1 year ago

Changes since my last push:

Link to the rendered documentation: https://github.com/nuttyartist/notes/blob/95f335bb957405db3e54b85763c65427da5f1252/docs/build_on_linux.md

nuttyartist commented 1 year ago

Awesome stuff.

I think we should explain to people using what commands they can install the required dependencies. The guide goes into good detail on how to build and install notes, but maybe they'll get stuck at the first step.

guihkx commented 1 year ago

I think we should explain to people using what commands they can install the required dependencies

I don't know... In my opinion, building a program from source is a very advanced topic already, so people who decide to actually do it should, at the very least, be familiar with installing packages on their distro (but if they don't, they can easily find out using Google).

I think documenting how to install the deb/rpm packages we offer is valid, though. But I think this should be added on a different document, maybe:

Thoughts?

zjeffer commented 1 year ago

I like that idea, will be useful especially for Linux: we could list the official package for every package manager/distro we support.

nuttyartist commented 1 year ago

Sounds good 👍

guihkx commented 1 year ago

Actually, let me merge this now and I'll address the documentation about installation in a separate PR, which will probably be big...