nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://www.get-notes.com
Mozilla Public License 2.0
3.6k stars 316 forks source link

CI: Unify build jobs with reusable workflows #583

Closed guihkx closed 1 year ago

guihkx commented 1 year ago

Instead of having individual workflow runs for every git operation, we can instead make them 'reusable' and then bundle all of them into a single, central workflow (which we will call CI).

Having them unified into a single workflow like that has several advantages:

Finally, if for some reason we want to run a specific workflow individually (instead of running of all them), I've kept the workflow_dispatch option in each workflow, so we can always dispatch them manually.

guihkx commented 1 year ago

This setup looks kinda convoluted if you view it from the Checks tab in this pull request, but if you go to the Actions page instead, it looks much better, IMO.

Anyway, let me know your thoughts.

nuttyartist commented 1 year ago

I like it too! Looks much better this way, when everything is in one place.

guihkx commented 1 year ago

Awesome! :smile:

guihkx commented 1 year ago

I just pushed a commit (https://github.com/nuttyartist/notes/commit/5b76489d2f8bb5d4feb782e7049645e7676c8572) directly into master to address the failing macOS build, which was caused by the lack of access to GitHub Secrets.