nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://www.get-notes.com
Mozilla Public License 2.0
3.6k stars 316 forks source link

Implement Pro version payment #601

Closed nuttyartist closed 11 months ago

nuttyartist commented 11 months ago

This PR implements the payment system for the Pro version. The checkout link is in test mode, soon I'll update it to production.

nuttyartist commented 11 months ago

@guihkx Thanks for the awesome feedback!

However, I have my doubts of how users (i.e. people who don't know how to build from source) will feel about this. And depending on their reaction, it's possible that you end up losing a large portion of your user base, which are mostly composed of non-tech-savvy Windows users.

Do you mean that the message about building from source will confuse them? Do you think it's better to remove it?

But in the end, you're the owner of the project, so it's your call. :)

Still apprieciate all feedback, so thanks.

Right now, all binaries built by the CI don't have access to 'PRO features', and that includes binaries for Linux users, i.e.: The AppImage, the deb packages and the rpm packages are all 'limited'.

Do you intend to keep this as-is? On the same subject, since we maintain the Flatpak and Snap packages, do you intend to make 'PRO features' unavailable for these users as well?

Yes. My end goal is to make the app completely free to use (i.e. no Pro version) and only charge for what truly make sense for this kind of app - built-in sync. But untl that is implemented, considering my somewhat challenging fiscal landscape, I'm trying the best I can to moentize the Pro version to a certain extent.

Anyway, regarding the changes itself, I just built with -DPRO_VERSION=ON on my Linux machine, but 'PRO features' are still locked:

That's weird. I'll look into that.

nuttyartist commented 11 months ago

I think I solved all the issues you pointed at except, what to do about the Qt version in the macOS build? Revert it to 6.5.0?

nuttyartist commented 11 months ago

Hahah, no that's not what I meant. I was just expressing concern that some users might get annoyed by this change and switch to a different program. So the message can stay and hopefully that doesn't happen.

Oh okay, gotcha. I hope so too.

Gotcha. So, as a reminder to yourself, when you release a new version, you'll have to add -DPRO_VERSION=OFF to our Flatpak manifest as well.

👍

No need to. I just think it's a change that needs its own separate commit, since it's not directly related to the feature you're adding. It's usually done by rebasing this branch against master and then force-pushing. But if you can't figure out how to do it, I can do it later...

It'd be good if you could learn rebasing though, just so you could keep your commits as clean as possible, and as quick as possible too, just so the list of commits doesn't get too large before we inevitably need to clean it up before the PR is finally merged.

I promise I will study git properly after this release. 😅

nuttyartist commented 11 months ago

@guihkx Should it be -DPRO_VERSION='OFF'or -DPRO_VERSION=OFF?

And on Windows, rather than

-DPRO_VERSION='OFF' \

Should it be

-DPRO_VERSION='OFF' `
guihkx commented 11 months ago

@guihkx Should it be -DPRO_VERSION='OFF'or -DPRO_VERSION=OFF?

I think both variants will work the same, but I personally choose no quotes.

And on Windows, rather than

-DPRO_VERSION='OFF' \

Should it be

-DPRO_VERSION='OFF' `

Yes.

guihkx commented 11 months ago

image

I think the size of the font on these two links at the bottom of the window could be just a tiny bit bigger. And since they're clickable links, the mouse cursor could be changed to a pointing hand. And maybe use a different color for the text?

nuttyartist commented 11 months ago

image

I think the size of the font on these two links at the bottom of the window could be just a tiny bit bigger. And since they're clickable links, the mouse cursor could be changed to a pointing hand. And maybe use a different color for the text?

Done. Let me know if you think we can merge this.