search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://www.get-notes.com
Mozilla Public License 2.0
3.6k stars 316 forks source link

CI/Windows: Use OpenSSL 1.x binaries from FireDaemon #653

Closed guihkx closed 7 months ago

guihkx commented 8 months ago

This fixes the Windows builds.

Now that Qt 6.5+ relies on OpenSSL 3.x, Qt (the company) has deleted from their servers the OpenSSL 1.x binaries they used to provide for Windows.

However, since we still use Qt 5.15 / 6.4, we still need those OpenSSL 1.x binaries, so we have to download them from elsewhere.

I decided to go with OpenSSL binaries built by FireDaemon, as they're free, have no external dependencies (i.e. MSVC), work on Windows 7, and have the additional benefit of being digitally signed.

nuttyartist commented 8 months ago

Awesome. I'm going to test this tomorrow. What Windows version did you test this on?

guihkx commented 8 months ago

I'm going to test this tomorrow

No problem.

What Windows version did you test this on?

Only on Windows 7, via QEMU.

They have this compatibility table which mentions Windows 7 being "compatible, but not supported". Only Windows 10 and 11 are actually "supported".

I also just force-pushed to adjust the commit message.

nuttyartist commented 7 months ago

Seems to work well on Windows 10 as well, thanks @guihkx!

nuttyartist commented 7 months ago

I see there are 2 failed builds. Why is that?

zjeffer commented 7 months ago

They seemed to have timed out (they were running for more than 3 hours). I managed to restart the macOS homebrew qt5 build, let's see how that goes.

guihkx commented 7 months ago

Homebrew seems to have stopped distributing Qt binaries for the macOS version we're currently using (Big Sur), which means they will be built from source, which means it will take ages and GitHub Actions will eventually time out.

See #654

nuttyartist commented 7 months ago

Oh damn, it was still going. Alrighty, merging...