search

nuttyartist / notes

Fast and beautiful note-taking app written in C++. Write down your thoughts.
https://www.get-notes.com
Mozilla Public License 2.0
3.6k stars 316 forks source link

Use Docker files for Linux workflows #666

Closed zjeffer closed 4 months ago

zjeffer commented 4 months ago

This PR converts the rest of the linux workflows to use docker images, speeding up the CI/CD.

nuttyartist commented 4 months ago

Awesomee, thanks, @zjeffer!

zjeffer commented 4 months ago

I'm not 100% sure how Docker works, but from I understand, ideally, these images have to be kept constantly up to date, right?

Correct.

If that's the case, can we somehow automate the updating and publishing of these images?

Yes, that should be possible. We should be able to automatically build these every week or so, for example. Will look into this maybe next weekend when I have more time.

I understand GitHub itself also has it's own OCI Registry, correct? So, it'd be really awesome if we could integrate that here, instead of having to dump all this maintenance work on you.

In my experence, the GitHub container registry is extremely slow to upload/download from. That's why I always use the official Docker registry. It should still be possible to automate the builds with this, so there won't be any maintanance work from my side.