search

nuvo / cain

Backup and restore tool for Cassandra on Kubernetes
Apache License 2.0
32 stars 21 forks source link

Makes BackupKeyspaceSchema return an error on failure #23

Closed gyant closed 4 years ago

gyant commented 4 years ago

Ran into an issue where a coworker had introduced some s3 bucket policies that strictly enforced encryption headers. They weren't required because the backup bucket had default server-side encryption enabled and the aws sdk took care of all of that on the backend. However, since this return block did not include the error, the app kept on rolling into the copy step and we were getting 404 errors in the logs because the entire path prefix had been wiped out because of this return. Took me all day to narrow down so thought I'd PR this to save someone else the headache if they ever run into this issue.

maorfr commented 4 years ago

Thanks for this!

This seems harmless enough, and thanks for the explanation.

@tomklino objections to merging this? if none, I'll merge within a couple of days.

lanefu commented 4 years ago

@maorfr still make sense to merge?