search

nuvo / skbn

Copy files and directories between Kubernetes and cloud storage
Apache License 2.0
74 stars 76 forks source link

Add support for Google Cloud Storage #10

Open mr-smithers-excellent opened 5 years ago

mr-smithers-excellent commented 5 years ago

It would be great to include Google Cloud Storage in this offering to ensure all major cloud providers are covered by this tool.

maorfr commented 5 years ago

Hey @mr-smithers-excellent,

We would like to have it as well! Would you like to get involved and add that capability? No doubt it would be a great addition ;)

mr-smithers-excellent commented 5 years ago

Hi @maorfr - I thought I might be volunteering for this :)

Sure, I can take it on. Do you have any contributing guidelines that need to be followed?

maorfr commented 5 years ago

Thanks!

No specific guidelines, I hope the code will be a guide on its own. pkg/skbn.go is the wrapper for all different clients. I would expect a pkg/gcs.go to be added, and I suggest that pkg/s3.go will be the example to follow.

Looking forward for your PR ;)

Simon3 commented 5 years ago

Hi, any progress on this ?

mr-smithers-excellent commented 5 years ago

I should be able to make this a priority this week.

Simon3 commented 5 years ago

I have actually just finished integrating it. Just need to review it quickly and I should be able to send a PR by tomorrow :)

mr-smithers-excellent commented 5 years ago

One less thing on my list for the week then. Excited to test it out!

Simon3 commented 5 years ago

PR sent (#12), don't hesitate to leave a few comments if you have modification suggestions!

benhoIIand commented 5 years ago

@maorfr could you have a look at the PR? We'd love this feature as well.

maorfr commented 5 years ago

as this repo has gone unmaintained, this feature is now a part of https://github.com/maorfr/skbn