Sanitise hyphens when using pattern id as theme hook

nuvoleweb / ui_patterns

[NOTE] Development has moved to https://drupal.org/project/ui_patterns

https://drupal.org/project/ui_patterns

GNU General Public License v2.0

85 stars 56 forks source link

Sanitise hyphens when using pattern id as theme hook #270

Closed gambry closed 4 years ago

gambry commented 5 years ago

With #243 we allowed hyphens as pattern id. Although this work perfectly, we haven't fully tested overriding patterns template through theme suggestions.

And indeed if there is a hyphen in the pattern id, overrides are not loaded.

This PR address this bug.

gambry commented 4 years ago

I've added the suggested changes + provided some test coverage for the overrides.

gambry commented 4 years ago

I closed this branch in order to resync fork HEAD with this repo. I issued a new PR: #295 .