Drupal 9 compatibility

[pdureau]

Hi all,

Drupal 9 is coming in 2 months. According to drupal-check, there are 7 compatibility issues with ui_patterns project (autoloading issues removed):

• modules/ui_patterns_library/tests/src/FunctionalJavascript/UiPatternsLibraryOverviewTest.php | 31 | Call to deprecated method setDefault() of class Drupal\Core\Extension\ThemeHandler. Deprecated in drupal:8.2.0 and is removed from drupal:9.0.0. Use the configuration system to edit the system.theme config directly.
• modules/ui_patterns_views/ui_patterns_views.module | 50 | Call to deprecated function drupal_set_message(). Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
• src/Plugin/Deriver/AbstractPatternsDeriver.php | 85 | Call to deprecated function drupal_set_message(). Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
• src/Plugin/Deriver/AbstractPatternsDeriver.php | 92 | Call to deprecated function drupal_set_message(). Deprecated in drupal:8.5.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
• src/Plugin/Deriver/AbstractYamlPatternsDeriver.php | 24 | Call to deprecated function file_scan_directory(). Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
• src/Plugin/PatternSourceBase.php | 15 | Class Drupal\ui_patterns\Plugin\PatternSourceBase implements deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface: Drupal\Component\Plugin\ConfigurablePluginInterface is deprecated in Drupal 8.7.0 and will be removed before Drupal 9.0.0. You should implement ConfigurableInterface and/or DependentPluginInterface directly as needed. If you implement ConfigurableInterface you may choose to implement ConfigurablePluginInterface in Drupal 8 as well for maximum compatibility, however this must be removed prior to Drupal 9.
• tests/src/Kernel/Plugin/PatternBaseTest.php | 52 | Return type of method Drupal\Tests\ui_patterns\Kernel\Plugin\PatternBaseTest::getUiPatternBaseMock() has typehint with deprecated interface PHPUnit_Framework_MockObject_MockObject: Use PHPUnit\Framework\MockObject\MockObject instead

Once done, we need to change all info.yml files:

Add core_version_requirement: ^8 || ^9 to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

I would be glad to do a pull request for that. But I am not sure the maintaining team is still very active and available to review it.

[paulmoloneyuk]

I've tried to make a start on this - do we know the status of the maintenance team for this module? My team would love to help get this D9 ready!

[ademarco]

Hello everyone, @yenyasinn will take care of it! :+1:

[pdureau]

great ! thanks @yenyasinn

[yenyasinn]

https://www.drupal.org/project/ui_patterns/releases/8.x-1.2 has been released.

[gambry]

The changes on src/Plugin/Deriver/AbstractYamlPatternsDeriver.php have probably broken any site using any module or theme without a templates/ folder.

In fact the deprecation change record suggestion has not been correctly followed as is_dir() should be run before scanning the directory for fully compatibility.

I will file a PR to fix this.