search

nuvoleweb / ui_patterns

[NOTE] Development has moved to https://drupal.org/project/ui_patterns
https://drupal.org/project/ui_patterns
GNU General Public License v2.0
85 stars 56 forks source link

Drupal 9 compatibility #292

Closed ademarco closed 4 years ago

ademarco commented 4 years ago

291

jigarius commented 4 years ago

Cool! Applied the patch to 1.x-dev and it is now compatible with Drupal 9. I'll be waiting for the official release 😄 Thanks!

jigarius commented 4 years ago

Although applying a path with this PR makes the module Drupal 9 compatible, the following line in the ui_patterns.info.yml doesn't allow me to install Drupal 9:

dependencies:
  - drupal:system (>=8.3.0)

Also, dependencies might need to be adjusted in the composer.json file for the UI patterns module to allow Drupal 9 installation.

yenyasinn commented 4 years ago

@jigarius I've removed this dependency. I suppose it is outdated. Please test.

jigarius commented 4 years ago

I get these errors when I do composer require drupal/core:9.0 --update-with-all-dependencies, but I think that's because the changes in this PR are not published to drupal.org.

Problem 1
    - drupal/core 8.4.x-dev requires symfony/class-loader ~3.2.8 -> no matching package found.
    - drupal/core 8.3.x-dev requires symfony/class-loader ~2.8 -> no matching package found.
    - drupal/ui_patterns 1.x-dev requires drupal/core ^8.3.0 -> satisfiable by drupal/core[8.3.x-dev, 8.4.x-dev, 8.5.x-dev, 8.7.x-dev, 8.8.x-dev, 8.9.x-dev].
    - drupal/ui_patterns 1.x-dev requires drupal/core ^8.3.0 -> satisfiable by drupal/core[8.3.x-dev, 8.4.x-dev, 8.5.x-dev, 8.7.x-dev, 8.8.x-dev, 8.9.x-dev].
    - drupal/ui_patterns 1.x-dev requires drupal/core ^8.3.0 -> satisfiable by drupal/core[8.3.x-dev, 8.4.x-dev, 8.5.x-dev, 8.7.x-dev, 8.8.x-dev, 8.9.x-dev].
    - Can only install one of: drupal/core[9.0.0, 8.8.x-dev].
    - Can only install one of: drupal/core[9.0.0, 8.9.x-dev].
    - Can only install one of: drupal/core[9.0.0, 8.5.x-dev].
    - Can only install one of: drupal/core[9.0.0, 8.7.x-dev].
    - Installation request for drupal/core 9.0 -> satisfiable by drupal/core[9.0.0].
    - Installation request for drupal/ui_patterns 1.x-dev -> satisfiable by drupal/ui_patterns[1.x-dev].

So, I'm trying to update core without UI Patterns. After I succeed to update core without UI Patterns, I'll drop in the latest version of UI Patterns with a patch of this PR and let you know how it goes.

jigarius commented 4 years ago

So, I upgraded to Drupal 9 without UI Patterns and then installed the ui patterns 8.x-1.x with a patch of this PR. Everything works correctly on Drupal 9.

IMO, the next step will be to finalize these changes and at least pushing them to Drupal.org so that the module can be installed using composer on Drupal 9 sites.

PS: Thanks again for maintaining the module. I submitted a couple of PRs a year ago. It'll be great if you could take a look.