search

nuvoleweb / ui_patterns

[NOTE] Development has moved to https://drupal.org/project/ui_patterns
https://drupal.org/project/ui_patterns
GNU General Public License v2.0
85 stars 56 forks source link

Issue#304: Detect all theme patterns. #318

Closed kp77 closed 1 year ago

kp77 commented 3 years ago

This PR attempts to solve multiple issues originating from the \Drupal\ui_patterns_library\Plugin\Deriver\LibraryDeriver::getDirectories method collecting only the default theme and the base theme directories.

Besides the issues described in #304 and #308, I also had errors during site install with existing config, when using patterns in layout builder, because during install the default theme is stark.

This PR is a follow up to PRs #305 and #310 and uses the method suggested here: https://github.com/nuvoleweb/ui_patterns/issues/304#issuecomment-687164731

vever001 commented 3 years ago

+1 on this! Thanks @kp77 this is IMO the proper fix.

geek-andi commented 2 years ago

This just solved our problem with patterns not showing up in a multi-domain setup, where we use a different theme for each domain:

Our steps to reproduce

(We only use patterns on domain 2)

Oddly, once we deinstall ui_patterns_library, the patterns will never show up.

mika2na commented 1 year ago

Moved to Drupal.org https://www.drupal.org/project/ui_patterns/issues/3311471