search

nuwave / lighthouse

A framework for serving GraphQL from Laravel
https://lighthouse-php.com
MIT License
3.36k stars 438 forks source link

Support Laravel 11 #2508

Closed spawnia closed 6 months ago

spawnia commented 7 months ago

Changes

Allow installation alongside Laravel 11.

Breaking changes

None.

spawnia commented 7 months ago

Requires https://github.com/BenSampo/laravel-enum/pull/353.

elliottlawson commented 6 months ago

@spawnia would like to pull this in on a Laravel 11 project, anything I can help with to move this forward?

chojnicki commented 6 months ago

Requires BenSampo/laravel-enum#353.

@spawnia Hmm but why lighthouse cannot work with PHP native enums? Even author suggests not to use that package.

Edit: Now I see that you are maintaining laravel-enums, and you actually commited "Using this library is no longer recommended", so I'm now even more confused :P

vanbosse commented 6 months ago

@spawnia can we help you out in order to push this forward?

spawnia commented 6 months ago

@spawnia can we help you out in order to push this forward?

Sure, thank you for the offer. I just pushed a change to allow the CI pipelines to run in principle. You can send a merge request that targets this branch and fixes some of the issues in PHPUnit or PHPStan.

nhedger commented 6 months ago

@spawnia I'm assuming you're dropping Lumen support. I can send a PR that removes references to Lumen that PHPStan complains about if you're ok with it.

spawnia commented 6 months ago

@spawnia I'm assuming you're dropping Lumen support. I can send a PR that removes references to Lumen that PHPStan complains about if you're ok with it.

I am not planning to drop support just yet. It is just impossible to install alongside Laravel 11 for testing, so I am dropping it as a dev dependency. We can just ignore the PHPStan errors.

chojnicki commented 6 months ago

I am not planning to drop support just yet.

I hope you meant "never" ❤️

nhedger commented 6 months ago

@spawnia I'm assuming you're dropping Lumen support. I can send a PR that removes references to Lumen that PHPStan complains about if you're ok with it.

I am not planning to drop support just yet. It is just impossible to install alongside Laravel 11 for testing, so I am dropping it as a dev dependency. We can just ignore the PHPStan errors.

Sounds good!

spawnia commented 6 months ago

Thank you @nhedger. Released with https://github.com/nuwave/lighthouse/releases/tag/v6.36.0.

njoguamos commented 6 months ago

Thank you all.

nhedger commented 6 months ago

Thank you @spawnia!