search

nuwave / lighthouse

A framework for serving GraphQL from Laravel
https://lighthouse-php.com
MIT License
3.36k stars 438 forks source link

Fix support for Laravel 11 #2532

Closed nhedger closed 6 months ago

nhedger commented 6 months ago

Changes

WIP

Breaking changes

spawnia commented 6 months ago

Looks good so far. Thank you for tackling this.

nhedger commented 6 months ago

Some tests are failing with the following error:

Error: Child process error (exit code 1): ErrorException thrown in /home/runner/work/lighthouse/lighthouse/vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php on line 335 while loading bootstrap file /home/runner/work/lighthouse/lighthouse/vendor/larastan/larastan/bootstrap.php: symlink(): File exists

 -- ----------------------------------------------------------------------------------------------------------- 
     Error                                                                                                      
 -- ----------------------------------------------------------------------------------------------------------- 
     Child process error (exit code 1): ErrorException thrown in                                                
     /home/runner/work/lighthouse/lighthouse/vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php  
     on line 335 while loading bootstrap file                                                                   
     /home/runner/work/lighthouse/lighthouse/vendor/larastan/larastan/bootstrap.php:                            
     symlink(): File exists                                                                                     

 -- -----------------------------------------------------------------------------------------------------------

I don't think it's related to the upgrade, but rather an issue with the CI perhaps ?

spawnia commented 6 months ago

Some tests are failing with the following error:

Error: Child process error (exit code 1): ErrorException thrown in /home/runner/work/lighthouse/lighthouse/vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php on line 335 while loading bootstrap file /home/runner/work/lighthouse/lighthouse/vendor/larastan/larastan/bootstrap.php: symlink(): File exists

 -- ----------------------------------------------------------------------------------------------------------- 
     Error                                                                                                      
 -- ----------------------------------------------------------------------------------------------------------- 
     Child process error (exit code 1): ErrorException thrown in                                                
     /home/runner/work/lighthouse/lighthouse/vendor/laravel/framework/src/Illuminate/Filesystem/Filesystem.php  
     on line 335 while loading bootstrap file                                                                   
     /home/runner/work/lighthouse/lighthouse/vendor/larastan/larastan/bootstrap.php:                            
     symlink(): File exists                                                                                     

 -- -----------------------------------------------------------------------------------------------------------

I don't think it's related to the upgrade, but rather an issue with the CI perhaps ?

Yeah, I just do not get why that one always fails.

spawnia commented 6 months ago

Thanks, nicely done!