search

nuwave / lighthouse

A framework for serving GraphQL from Laravel
https://lighthouse-php.com
MIT License
3.37k stars 439 forks source link

Add `@withoutGlobalScopes` directive #2577

Closed saeed-rostami closed 4 months ago

saeed-rostami commented 5 months ago

add @withoutGlobalScopes directive which works on argument to ignore global scopes that are defined in the model.

type Query { posts ( allPosts (Bool @withoutGlobalScopes (names : ["scheduled"]) ) }

saeed-rostami commented 5 months ago

Hello should I add the directive description in the docs md file?

spawnia commented 5 months ago

Hello should I add the directive description in the docs md file?

Eventually, yeah. Let's make sure it is properly described first.

saeed-rostami commented 4 months ago

Thanks again, new commit pushed ...check the doc file please

spawnia commented 4 months ago

There is a typo in the title, and tests are failing.

saeed-rostami commented 4 months ago

There is a typo in the title, and tests are failing.

Can you give me more details about the test error?

spawnia commented 4 months ago

There is a typo in the title, and tests are failing.

Can you give me more details about the test error?

You can look at the results in https://github.com/nuwave/lighthouse/actions/runs/9746838503.

saeed-rostami commented 4 months ago

Ok..., I pushed another commit...hope will be succeed

spawnia commented 4 months ago

Ok..., I pushed another commit...hope will be succeed

You don't have to hope, you can run the tests locally. See https://github.com/nuwave/lighthouse/blob/master/CONTRIBUTING.md.

Please let me know when every comment has been addressed and CI passes.

saeed-rostami commented 4 months ago

Ok..., I pushed another commit...hope will be succeed

You don't have to hope, you can run the tests locally. See https://github.com/nuwave/lighthouse/blob/master/CONTRIBUTING.md.

Please let me know when every comment has been addressed and CI passes. I'm living in Iran...docker is sanctioned and the internet situation is bad ... but I will try anyway thanks

saeed-rostami commented 4 months ago

Finally, I tested locally and both tests were successful.

spawnia commented 4 months ago

Finally, I tested locally and both tests were successful.

There are still plenty of unresolved discussions. Please address them all.

saeed-rostami commented 4 months ago

Finally, I tested locally and both tests were successful.

There are still plenty of unresolved discussions. Please address them all.

please check them

saeed-rostami commented 4 months ago

NEW COMMIT PUSHED

spawnia commented 4 months ago

NEW COMMIT PUSHED

I am a bit irritated by your use of ALL CAPS.

Anyways, thanks for making the requested changes. I think I failed to communicate how I would like certain things to be done very specifically. The intent of your changes is clear, so I am going to go ahead and make smaller changes, I think that will be more efficient than going back and forth.