search

nuweba / faasbenchmark

Run or add generic tests to accurately benchmark FaaS providers. https://faastest.com/
Apache License 2.0
36 stars 7 forks source link

attempt to remove stack only if deployment was successful #45

Open nwb-ilan opened 4 years ago

nwb-ilan commented 4 years ago

Before this fix, when deploying IncreasingLoadLvl1 for example, and maven is not installed on my machine, I experience 10 retry attempts to remove the stack even though it failed to deploy.

Adir-Shemesh commented 4 years ago

The cleanup here is necessary - it's possible to encounter errors while trying to deploy a stack (invalid serverless.yml, too many stacks/buckets on the account, etc)

It's better to try the cleanup and fail if the stack wasn't deployed than not perform any cleanup.

I do believe we should rethink the retries though

nwb-ilan commented 4 years ago

Maybe we should make sure the reason why stack deploy failed is properly reflected, otherwise the stack will be deleted and it will be difficult to find out why

Adir-Shemesh commented 4 years ago

We don't deal with deploying the stack ourselves, it's sls's job to show why failures happened