nuxeh / url-bot-rs

Minimal IRC URL bot in Rust
ISC License
24 stars 13 forks source link

Add optional openssl/vendored dep #430

Closed polyzen closed 2 years ago

polyzen commented 2 years ago

Needed now for static builds.

I don't know if there are cases where one would want to install openssl/vendored or rusqlite/bundled separately. Perhaps they should be combined under a static target?

codecov[bot] commented 2 years ago

Codecov Report

Merging #430 (8f60d87) into master (4ceec66) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          11       11           
  Lines        1641     1641           
=======================================
  Hits         1401     1401           
  Misses        240      240           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ceec66...8f60d87. Read the comment docs.

nuxeh commented 2 years ago

Hey polyzen!

This seems like a good thing to have, thanks!

Regarding combining them, I think on balance it's better to have the option to have one or the other. I say this because on some platforms (Windows) I found it nigh on impossible to get sqlite dynamic libs, while openssl is somewhat easier, so there it's useful to specifically have the sqlite vendored, I think.

Nothing to suggest there couldn't be an additional static feature, which enables both of these, though. But my question there is, does that in itself make it a static build? I feel there are other steps required to end up with a static binary...

How you are doing your static builds these days? I'd still really like to be able to easily (from a user's perspective) have static builds, even having CI produce binaries for a couple of architectures and attach them to releases.

nuxeh commented 2 years ago

Just saw your messages on IRC, the musl/cargo method does look rather straightforward, hmm

nuxeh commented 2 years ago

So this seems to build just fine statically, thanks again @polyzen

nuxeh commented 2 years ago

Added a note to the readme ea9aa16c60be9b345d2e771d37f2fd296f188b59