nuxt-community / auth-module

Zero-boilerplate authentication support for Nuxt 2

https://auth.nuxtjs.org

MIT License

1.93k stars 924 forks source link

feat: added spotify oauth2 provider #1483

Closed Intevel closed 1 year ago

Intevel commented 2 years ago

Seperated in new PR

bmulholland commented 2 years ago

Please also add a "Login with Spotify" button to the demo site and ensure that's tested and working

Intevel commented 2 years ago

There is a button ^^

bmulholland commented 2 years ago

Oh haha -- thanks! :)

bmulholland commented 2 years ago

Thanks for requesting my review! That alerts me that it's ready to review in a respectful way -- please continue to use that for anything else you think is ready to go.

Intevel commented 2 years ago

But you have to merge this to: https://github.com/nuxt-community/auth-module/pull/1656

bmulholland commented 2 years ago

1656 is marked as draft. Is this PR dependent on #1656?

Intevel commented 2 years ago

Yes

bmulholland commented 2 years ago

The last comment on that PR says "When https://github.com/nuxt-community/auth-module/pull/1483 is merged, I will update this PR accordingly and test it again."

There appears to be a circular dependency, then. Can you please work out what order these should be merged in? And, if #1656 needs to be merged first, then it will need to be in a shippable state (and non-draft status) before I can merge it.

Intevel commented 2 years ago

I'm drafting this for now, I need to take another look at the two PR's.

bmulholland commented 2 years ago

Thanks for working on all that :). Dependencies like this can be annoying.