search

nuxt-community / axios-module

Secure and easy axios integration for Nuxt 2
https://axios.nuxtjs.org
MIT License
1.19k stars 246 forks source link

Brotli support removed #276

Open Francois-Francois opened 5 years ago

Francois-Francois commented 5 years ago

What problem does this feature solve?

In the past, Brotli was not supported on nodejs servers.

If I understand correctly, this is now supported since a few months : https://github.com/nodejs/node/pull/20458

This PR dropped support for Brotli : https://github.com/nuxt-community/axios-module/pull/180

Maybe it's time to revert this BR because Axios is supporting it too : https://github.com/axios/axios/pull/2071

What does the proposed changes look like?

Revert this PR https://github.com/nuxt-community/axios-module/pull/180

This feature request is available on Nuxt community (#c270)
manniL commented 5 years ago

Reverting isn't enough as Brotli isn't supported in all version. One would have to do a check like in axios/axios#2071

Other than that, I absolutely agree.

pi0 commented 4 years ago

Thanks @rikless for report.

ITJesse commented 4 years ago

As the axios is not support brotli now, you should drop server side Brotli support at this time.

ITJesse commented 4 years ago

I recommend revet this commit: https://github.com/nuxt-community/axios-module/commit/074f98cbdf409473357b2cd24cd6cb13fe75f149