feat!: rewrite with nuxt kit and nuxt 3 support

nuxt-community / feed-module

Everyone deserves RSS, ATOM and JSON feeds!

MIT License

226 stars 36 forks source link

feat!: rewrite with nuxt kit and nuxt 3 support #103

Closed maciejpedzich closed 2 years ago

pi0 commented 2 years ago

Thanks for the pull request @maciejpedzich. I've made an overall review this is in a nice direction.

It is fine to generally have customizations in repo setup. But ideally, it should be as close as possible with module starter to keep it's consistency with the rest of (new) nuxt-community modules and I would like to hear from @manniL preferences as he is the current maintainer.
Since we are rewriting the module with Nuxt 3 in mind, ideally should also follow its design goals. Mainly, integration with nitro with an API route to allow runtime generation of sitemap vs on build generation. We can do it later but have it in mind. In the meantime, Avoid async resolve function in nuxt.config and depend on nuxt hooks for extension. (added in review comments)

manniL commented 2 years ago

Thanks for the PR! I'll have a look in the next days ☺️

maciejpedzich commented 2 years ago

Hi @pi0, thanks for the review! Sorry for taking so long, luckily I've found time to properly get down to adjusting the code accordingly with the changes you've requested. I'll let you when I'm done correcting everything.

maciejpedzich commented 2 years ago

@manniL, @pi0 - I've decided to retire my custom Nuxt 3 compatible RSS feed module, and I'm afraid I won't be able to actively support the feed module as a community maintainer because I simply don't have the bandwidth to do it anymore. Feel free to reuse the code as a foundation for the official one.

manniL commented 2 years ago

@manniL, @pi0 - I've decided to retire my custom Nuxt 3 compatible RSS feed module, and I'm afraid I won't be able to actively support the feed module as a community maintainer because I simply don't have the bandwidth to do it anymore. Feel free to reuse the code as a foundation for the official one.

@maciejpedzich Thanks a lot for being that open and for the PR! I will try to move the module to Nuxt3 based on your code in near future (and give appropriate credits) 👍

heychazza commented 2 years ago

@manniL, @pi0 - I've decided to retire my custom Nuxt 3 compatible RSS feed module, and I'm afraid I won't be able to actively support the feed module as a community maintainer because I simply don't have the bandwidth to do it anymore. Feel free to reuse the code as a foundation for the official one.

@maciejpedzich Thanks a lot for being that open and for the PR! I will try to move the module to Nuxt3 based on your code in near future (and give appropriate credits) 👍

Hey folks, is there any working sitemap generator these days that supports Nuxt 3 and Nuxt Content V2?

xlanex6 commented 2 years ago

Hi @manniL

Is there a roadmap, todo list to finish the job initiate by @maciejpedzich ? I will need RSS feed on my Nuxt 3 project so... I'm ready to spend time and energy to finish what have to be done.

manniL commented 2 years ago

Feel free to check #106. I haven't had the time to continue from here, so whoever wants to take a stab is good to go ☺️