search

nuxt-community / feed-module

Everyone deserves RSS, ATOM and JSON feeds!
MIT License
227 stars 36 forks source link

feat: nuxt 3 support #108

Closed NozomuIkuta closed 1 year ago

NozomuIkuta commented 2 years ago

This draft PR aims to take over nuxt/framework#103 and resolves nuxt/framework#106.

At first, for the next major release, I triaged all the open issues as below (except Renovate Dependency Dashboard (#99)).

My implementation may include some breaking changes in API, as done in nuxt/framework#103, in a way that I believe is good and beneficial enough for users. I would like to discuss with authors and community while developing this PR.

This PR doesn't aim to add Docus-powered documentation, which is handled in nuxt/framework#103, so that we can keep this PR's "done of definition" manageable.

This PR message will be modified as needed.

TODOs

Out of Scope

provok-me commented 1 year ago

@NozomuIkuta where are you at?

NozomuIkuta commented 1 year ago

@provok-it

First of all, don't worry, I do never abandon this PR 🙌

My PR has been blocked by some issues as described in the PR message.

The biggest one is https://github.com/nuxt/nuxt.js/issues/13856. If I'm correct, this PR can't be completed without the hook.

@manniL

Perhaps can we use other hook like one of Nitro instead of generate hooks?

As for other blockers of new features and bug fixes, feed package doesn't seem to be so actively developed. Since "done is better than perfect", I'm thinking of postponing new features and bug fixes and focusing on making the module support Nuxt 3 at this moment.

I would like to hear the author's and the the community's thoughts.

By the way, JFYR, I'm also creating an alternative to feed package, with which I aim to resolve all the feed-related blockers. If people think it's worth changing the dependency, I could do that at some point (like @nuxt/feed v3?). At least, even if @nuxt/feed keep depending on feed, I would personally publish another feed module powered by my feed generator, just for R&D purpose.

manniL commented 1 year ago

I agree with the idea to provide a "feature-parity" module with Nuxt 3 support for now and then maybe another major version with a rewrite/revamp ☺️

NozomuIkuta commented 1 year ago

@manniL

Thank you for quick response! 😄

Then, once https://github.com/nuxt/nuxt.js/issues/13856 is resolved or we find another way, I will complete minimal implementation and make this PR ready for review. 🙋‍♂️

I appreciate any kinds of help. 🙏

manniL commented 1 year ago

@NozomuIkuta Maybe we can use a Nitro endpoint that renders the feed? Users can decide then if they want to pre-render it, use SWR or what not ☺️

provok-me commented 1 year ago

@NozomuIkuta You can probably use the build hook since SSG doesn't work in the same way it did in Nuxt 2. That's what the nuxt/sitemap module does.

What do you think about this @pi0?

NozomuIkuta commented 1 year ago

@pi0 @danielroe

Sorry to ask again, but I appreciated if you give us some information based on which we can make decisions about implementation, like we need to await upstream, or we can use a specific hook to achieve our needs.

manniL commented 1 year ago

@NozomuIkuta As I mentioned before, I'd go a similar way as you can add sitemaps now. See e.g. Daniel's blogpost

NozomuIkuta commented 1 year ago

Closed in favor of nuxt/framework#114.