nuxt-community / feed-module

Everyone deserves RSS, ATOM and JSON feeds!
MIT License
227 stars 36 forks source link

Fix name property error #2

Closed shooontan closed 6 years ago

shooontan commented 6 years ago

I have error with nuxt generate. I removed nuxt.hook('generate:extendRoutes') and added nuxt.hook('generate:done').

"dependencies": {
  nuxt": "^1.4.0"
},
"devDependencies": {
  @nuxtjs/feed": "^0.1.0"
}
 Generate errors summary:

 ROUTE  undefined

  TypeError: Cannot read property 'name' of undefined

  - vue-router.common.js:1278 normalizeLocation
    [lab_hp]/[vue-router]/dist/vue-router.common.js:1278:12

  - vue-router.common.js:2576 VueRouter.resolve
    [lab_hp]/[vue-router]/dist/vue-router.common.js:2576:18

  -
  -
codecov[bot] commented 6 years ago

Codecov Report

Merging #2 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          37     35    -2     
  Branches        4      4           
=====================================
- Hits           37     35    -2
Impacted Files Coverage Δ
lib/module.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30f228a...52a5155. Read the comment docs.

manniL commented 6 years ago

Hey @shooontan

Thanks for your PR! I've reviewed it and made some minor changes (eg. removing the "generator:done" hook).