search

nuxt-community / feed-module

Everyone deserves RSS, ATOM and JSON feeds!
MIT License
226 stars 36 forks source link

feed output in static folder #41

Closed tcurdt closed 5 years ago

tcurdt commented 5 years ago

Why is the plugin writing the feeds into the static folder? I would expect the files to only show up in the dist folder.

manniL commented 5 years ago

Contents from /static are copied over to the dist folder as well. ☺️

tcurdt commented 5 years ago

@manniL That might be true but is beside the point. It's writing a file into what essentially is a source (in contrast to a target) directory. Plugins should not write into static.

manniL commented 5 years ago

Good point! I'd accept a tested PR to change that behavior ☺️

ricardogobbosouza commented 5 years ago

@tcurdt I'm working on this module and it's on my list to do this as robots-module https://github.com/nuxt-community/robots-module/blob/master/lib/module.js#L27

manniL commented 5 years ago

@ricardogobbosouza be aware that you need a way to support dynamic SSR mode too. Similar goes for the robots-module I'd say.

Probably sth. like https://github.com/nuxt-community/sitemap-module/blob/dev/src/index.js#L28 could work. (But don't use hardcoded dist).