search

nuxt-community / feed-module

Everyone deserves RSS, ATOM and JSON feeds!
MIT License
226 stars 36 forks source link

feat(generate): feed output in generate folder BREAKING CHANGE #43

Closed ricardogobbosouza closed 5 years ago

ricardogobbosouza commented 5 years ago

Update module

BREAKING CHANGE

Resolve #41 Resolve #47 Resolve #49 Resolve #50 Resolve #52 Resolve #53 Resolve #54 Resolve #55

codecov[bot] commented 5 years ago

Codecov Report

Merging #43 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #43   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          50     49    -1     
  Branches        7      7           
=====================================
- Hits           50     49    -1
Impacted Files Coverage Δ
lib/module.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d0f71e...f840709. Read the comment docs.

manniL commented 5 years ago

This is a breaking change as the generation timing is moved from "before generation" to "after generation".

ricardogobbosouza commented 5 years ago

@manniL yeah

manniL commented 5 years ago

@ricardogobbosouza Could you fix the conflicts? I'll merge afterwards :+1:

ricardogobbosouza commented 5 years ago

ping @manniL

manniL commented 5 years ago

Thanks!

miteyema commented 4 years ago

@manniL @ricardogobbosouza Hi guys, can you make a new release of this merged commit? I think v1.1.0 still has the problem of the file being generated directly into the static folder...