search

nuxt-community / firebase-module

🔥 Easily integrate Firebase into your Nuxt project. 🔥
https://firebase.nuxtjs.org
MIT License
641 stars 98 forks source link

vague error message when required key is missing #412

Closed azeem-r00t closed 3 years ago

azeem-r00t commented 3 years ago

If the config doesn't include one of the required keys, you get an error message as follows:

ERROR Missing or incomplete config for current environment 'development'

This update improves the error message to include the missing key in the error so the user can address it easily without having to go look into this source code.

The new error message is as following (when databaseURL is not included in the config):

ERROR Missing or incomplete config for current environment 'development': key 'databaseURL' is required!

lupas commented 3 years ago

Hey @azeem-r00t Thanks a lot for the PR, appreciate it!

The error message looks better that way, looks good.

We don't allow merge to the Master branch, could you change/reopen the PR to point towards the dev branch?

Thanks a lot & Merry Christmas Pascal

azeem-r00t commented 3 years ago

I'll open it against dev. Thanks @lupas

azeem-r00t commented 3 years ago

Opened PR against dev branch. https://github.com/nuxt-community/firebase-module/pull/421