feat: add stories for `@nuxtjs/storybook`

nuxt-community / fontawesome-module

Module to use Font Awesome icons in Nuxt.js

MIT License

110 stars 12 forks source link

feat: add stories for `@nuxtjs/storybook` #20

Closed farnabaz closed 3 years ago

farnabaz commented 3 years ago

@nuxtjs/storybook does provide and custom hook for modules to register their own stories. https://github.com/nuxt-community/storybook/pull/129

This PR is a proposal for Icons story for font-awesome module

pimlie commented 3 years ago

@farnabaz Thank you for this pr and your work on the storybook module.

Could we make the inclusion of these module stories optional? Ie we shouldnt force module stories into existing storybook configs.

farnabaz commented 3 years ago

By default module stories will include in storybook but there is an exclude option in Storybook config that can be used to ignore modules.

pimlie commented 3 years ago

Ah nice. Could we add an entry to the readme about how storybook integrates with fontawesome module? I dont think its the sole responsibility of storybook module to inform people how evertyhing is supposed to work, but it can be just a link to the specific page about module integration in the storybook docs

farnabaz commented 3 years ago

It's great idea to add an entry in readme, I will create the entry, But first I have to release @nustjs/storybook.

farnabaz commented 3 years ago

I've made some changes.

Copy icon tag to clipboard on click
Create size control for icons

pimlie commented 3 years ago

@farnabaz Sorry for the delay, is this still good to merge?

farnabaz commented 3 years ago

@pimlie This is good for me 🙂

pimlie commented 3 years ago

Thanks!