search

nuxt-community / fontawesome-module

Module to use Font Awesome icons in Nuxt.js
MIT License
110 stars 12 forks source link

New icons import syntax doesnt support pro solid icons #3

Closed pimlie closed 4 years ago

pimlie commented 4 years ago

Solid icons comes both in a free as pro variant, currently only free is supported.

pimlie commented 4 years ago

@vaso2 @pi0 Could you guys share your thoughts about the best syntax to fix this?

  icons: {
    solidPro: true // special key
  }

// or

  pro: true, // top level key, meaning use pro when possible (only has use for solid icons though)
  icons: {
    solid: true
  }

// or

  icons: {
   solid: [
      'faHome'
    ],
    solid: { // support both array as object config, dont like the icons prop twice
      pro: true,
      icons: [
        'faHome'
      ]
    }
  }

any other ideas? My prefs would be 2 I think.

pimlie commented 4 years ago

Have opted to go for adding a new config key proIcons