search

nuxt-community / google-optimize-module

SSR friendly Google Optimize module for Nuxt.js
MIT License
215 stars 32 forks source link

isEligible should fire on route change #3

Open uptownhr opened 5 years ago

uptownhr commented 5 years ago

Maybe I'm not understanding the intent of isEligible but I feel this should be continuously checked as route is being changed. Resulting in a experiment being able to be inactive until a user reaches a certain route.

pi0 commented 5 years ago

PRs welcome for this enhancement :)

kwolniak commented 3 years ago

I would love to see this feature works with route change, for now isEligible looks usless.

farzadso commented 3 years ago

@kwolniak Someone started a PR for it a while ago: https://github.com/nuxt-community/google-optimize-module/pull/7

It would be great if you could continue the whole idea.