Closed JoaoPedroAS51 closed 3 years ago
Merging #14 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 10 10
Branches 1 1
=========================================
Hits 10 10
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b525a68...66e0111. Read the comment docs.
Hi @JoaoPedroAS51 It looks good, can we merge?
Hi @ricardogobbosouza! Unfortunately we can't merge it yet. We are making more refactors before release v5 and I will probably need to update this PR again :)
Any update on this!?
We're using auth-next
because of token refresh capability and we still have problem with laravel-echo
, I have to move our app to production in few days and still didn't find any solution to support this lib as well!!!
@JoaoPedroAS51 @ricardogobbosouza
Hi @iranagame! You can use my fork until we merge this PR :)
Just add something like "@nuxtjs/laravel-echo": "JoaoPedroAS51/laravel-echo#feat/auth-v5"
to your package.json
I believe this changed the method for getting the token from $auth.token.get()
to $auth.strategy.token.get()
. Due to this change, this PR is currently broken. I left a comment on the plugin.js file with a fix that I can verify works.
@JoaoPedroAS51 can you take a verify my fix is correct and update the code? We're trying to use this package with Auth v5 and cannot until this is fixed. Thanks so much!
@aaronhuisinga Done! :)
@ricardogobbosouza Can this package have a beta version? That way we could merge this PR :)
Thanks @JoaoPedroAS51!
Sure @JoaoPedroAS51 I'll do it this week
Thanks so much for all your work on this @JoaoPedroAS51 and @ricardogobbosouza!
@ricardogobbosouza Any plans to get this merged into a pre-release version?
Hi @aaronhuisinga I'll do it until the end of January Sorry for the delay
Apologies for the delay Releasing an alpha version today 😄
This PR migrate from auth module v4 to v5. It also add referer and x-xsrf-token headers to work with laravel sanctum provider.
Closes #10