Extract bulma-module - Githubissues

nuxt-community / legacy-modules

MIT License

1.28k stars 158 forks source link

Extract bulma-module #398

Closed Geminii closed 3 years ago

Geminii commented 3 years ago

I don't find any repository on nuxt-community/bulma-module

Tasks :

[x] extract the module (https://github.com/Geminii/bulma-module)
[x] reorganize module
[x] add nuxt/test-utils
[x] add eslint
[x] add example
[ ] transfer into nuxt-community repo
[ ] update awesome-nuxt bulma module link
[ ] update modules.nuxtjs.org bulma module link
[x] create a PR to remove bulma into this repository (https://github.com/nuxt-community/community-modules/pull/399)

@pi0 @Atinux

Atinux commented 3 years ago

I am wondering if this is required since it is only adding a CSS file :thinking:

Also, buefy is doing a great job and has a Nuxt installation: https://buefy.org/documentation/start#nuxtjs

Geminii commented 3 years ago

I am wondering if this is required since it is only adding a CSS file 🤔

Yes for the moment, this module only include a css file but maybe we can evolve the module ? Add some configurations or other ? Dunno if there is an interest about it?

Also, buefy is doing a great job and has a Nuxt installation: https://buefy.org/documentation/start#nuxtjs

Buefy is based on Bulma and there is already a module for it (https://github.com/buefy/nuxt-buefy). If a developper want to only include Bulma without Buefy addons, do you think in this case that Buefy need to be include in this context ?

Atinux commented 3 years ago

Yes for the moment, this module only include a css file but maybe we can evolve the module ? Add some configurations or other ? Dunno if there is an interest about it?

I don't think a module for this is necessary honestly. Great documentation about adding CSS frameworks in Nuxt should be enough.

If a developper want to only include Bulma without Buefy addons, do you think in this case that Buefy need to be include in this context ?

Then he simply need to:

yarn add --dev bulma

And set in his nuxt.config.js:

export default {
  css: ['bulma/css/bulma.css']
}

Is it as fast as using a module and can upgrade more easily.

CC @pi0, what do you think?

pi0 commented 3 years ago

Fully agree. With buefiy, this module doesn't makes sense anymore and should be deprecated. Also made issue for CNA removal: https://github.com/nuxt/create-nuxt-app/issues/694

Geminii commented 3 years ago

Ok in this way, i will remove the bulma-module. It make no sense to keep it 😅