Closed andre-brdoch closed 4 years ago
Merging #11 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 25 38 +13
Branches 2 5 +3
=========================================
+ Hits 25 38 +13
Impacted Files | Coverage Δ | |
---|---|---|
lib/module.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 654fd78...f8c55c7. Read the comment docs.
Well done! 👍🏻
thank you! ☺️ thanks for reviewing
@andre-brdoch Will bundle a release in the coming days 😉
It would probably make sense to change the nuxt hook to
generate:distRemoved
, since certain things like env var might need to be accessible earlier on already. I just was not sure if there would be any downsides to this.This is my first time contributing to an open source project, and first time using conventional commit messages, so I hope I did things correctly :) feedback is very welcome
Resolves #4