search

nuxt-community / pwa-module

Zero config PWA solution for Nuxt.js
https://pwa.nuxtjs.org
MIT License
1.24k stars 171 forks source link

fix(meta): add missing `hid` to icon tags #428

Closed buoto closed 3 years ago

buoto commented 3 years ago

The favicon head links were pushed without hid and name and they weren't deduplicated in mergeMeta: https://github.com/nuxt-community/pwa-module/blob/245aadc3c3111c1eff0bf18ff775bb248a708867/lib/meta.utils.js#L13-L19 As a result they were appended every time the page was visited, causing a memory leak and crashing the server after some time.

codecov[bot] commented 3 years ago

Codecov Report

Merging #428 (d477c38) into master (245aadc) will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files           9        9           
  Lines         367      367           
  Branches      122      122           
=======================================
  Hits          313      313           
  Misses         54       54
Impacted Files Coverage Δ
src/meta.ts 78.78% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 245aadc...d477c38. Read the comment docs.

pi0 commented 3 years ago

https://github.com/nuxt-community/pwa-module/releases/tag/v3.3.5