nuxt-community / pwa-module

Zero config PWA solution for Nuxt.js
https://pwa.nuxtjs.org
MIT License
1.23k stars 171 forks source link

short_name uses package.json name by default instead of manifest name #544

Open PetroSilenius opened 1 year ago

PetroSilenius commented 1 year ago

Currently if short_name is not provided in the manifest config it will default to package.json name https://github.com/nuxt-community/pwa-module/blob/79322c18a28456a02ef0c3c596dff6cd88389f59/src/manifest.ts#L11

While docs describe this behaviour like this The short_name (maximum of 12 characters recommended) is a short version of the app's name. It is an optional field and if not specified, the name will be used, > though it will likely be truncated. https://pwa.nuxtjs.org/manifest#short_name

Based on docs I got the impression that the default value for short_name would be the name property in the pwa manifest but that doesn't appear to be the case.

Which one is wanted behaviour here? Should the docs be updated to match current behaviour or should the implementation be updated to match docs?