nuxt-community / router-module

Nuxt 2 module to use router.js instead of pages/ directory.

MIT License

401 stars 28 forks source link

feat(createRouter): Add the store parameter to the customCreateRouter function #105

Closed loick closed 2 years ago

loick commented 3 years ago

Nuxt release 2.16 https://github.com/nuxt/nuxt.js/pull/9660

Context: The router now supports a "store" parameter (starting the Nuxt 2.16 release).

codecov[bot] commented 3 years ago

Codecov Report

Merging #105 (428d4e7) into main (18bb2d3) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 428d4e7 differs from pull request most recent head 1c365ea. Consider uploading reports for the commit 1c365ea to get more accurate results

@@            Coverage Diff            @@
##              main      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           21        21           
  Branches         4         4           
=========================================
  Hits            21        21

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18bb2d3...1c365ea. Read the comment docs.

loick commented 3 years ago

I'll come back here to merge this PR once the nuxt release will be done, if it's fine by you @danielroe, in order to merge this (& release afterwards?)

Thanks 🙏

loick commented 2 years ago

@danielroe what do you think about releasing it now, in order to be able to use it with nuxt-edge?

loick commented 2 years ago

@danielroe is it possible?